Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more uses of oftype #51

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Remove more uses of oftype #51

merged 4 commits into from
Mar 13, 2023

Conversation

sostock
Copy link
Owner

@sostock sostock commented Mar 10, 2023

No description provided.

sostock referenced this pull request Mar 10, 2023
… two (#49)

* change promotion in rational conversion

* Use twice in unsafe_rational

Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>

* update other constructors

* Add test

* Update test/customtypes.jl

Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>

---------

Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (82a8348) 99.20% compared to head (cc3c33c) 99.20%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files           1        1           
  Lines         250      250           
=======================================
  Hits          248      248           
  Misses          2        2           
Impacted Files Coverage Δ
src/HalfIntegers.jl 99.20% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sostock sostock merged commit f3661b8 into master Mar 13, 2023
@sostock sostock deleted the remove_more_oftype branch March 13, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants