Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive filtering in HTML tables #924

Closed
PhilippWendler opened this issue Oct 13, 2023 · 3 comments · Fixed by #1004
Closed

Case-insensitive filtering in HTML tables #924

PhilippWendler opened this issue Oct 13, 2023 · 3 comments · Fixed by #1004

Comments

@PhilippWendler
Copy link
Member

In our HTML tables, it is natural to be able to want to filter in a case-insensitive way, for example with regards to task names or other textual columns. We could support this via a checkbox in the filter overlay.

@kfriedberger
Copy link
Member

It might be easier to just filter case-insensitive and to not provide the user a new checkbox for that. If any user later explicitly requests a specific feature for case-sensitive filtering, then think about adding the checkbox.

@JawHawk
Copy link
Member

JawHawk commented Feb 28, 2024

@PhilippWendler For case-insensitive way, I am converting the strings to lowercase and then comparing. Please review my PR #1004 if the changes are acceptable. Attached is the working video of the same.

CaseInsensitiveFiltering-2024-02-29_02.44.52.mp4

Also Thank you for merging my previous PR #1002. But I didn't check the text-filtering before commit 47cd777 and it was producing an error . Here is the screenshot of it. I sincerely apologize for my oversight and it will not happen again. I have added a commit Fixed setDisableTaskText error to fix that.

Screenshot_20240229_020506

@PhilippWendler
Copy link
Member Author

It might be easier to just filter case-insensitive and to not provide the user a new checkbox for that. If any user later explicitly requests a specific feature for case-sensitive filtering, then think about adding the checkbox.

Indeed. A small internal poll in our group also produced 100% support for this, so let's proceed in this manner (as done in #1004).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants