Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed status drop down initial display #1002

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

JawHawk
Copy link
Member

@JawHawk JawHawk commented Feb 27, 2024

Fixes #830

Fixed the display on initial render by defining a function named getNewFileteredColumnValues. It returns the new Filtered Column Value and is subsequently used in useEffect to display changes on changing Filters.

Copy link
Member

@PhilippWendler PhilippWendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I can confirm that the fix works for me. 🎉

I have just a few minor suggestions, it would be great if you could update the PR. Also, could you leave out the changes to the package-lock.json? We want to update dependencies separately.

@JawHawk
Copy link
Member Author

JawHawk commented Feb 28, 2024

@PhilippWendler I have made the requested changes. Please review

@PhilippWendler
Copy link
Member

We have pre-built versions of the React applications in the repository to make it easier for non-JS developers, so when one changes the JS code, these builds also needs to be updated by running npm run build. Unfortunately, sometimes slight version changes influence the result somewhat (similar to the changes for package-lock.json, I guess), which we want to avoid, so I just ran the build and pushed now. The container with node:12, then npm ci and then npm run build works best for me to create this build in the desired manner.

@PhilippWendler PhilippWendler merged commit 71c8842 into sosy-lab:main Feb 28, 2024
3 of 4 checks passed
@PhilippWendler
Copy link
Member

And merged! Thanks a lot for your fix and for your quick reactions, this was a great first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Status drop-down does not correctly display on initial render
2 participants