Skip to content
This repository has been archived by the owner on Oct 3, 2021. It is now read-only.

"Repeated" benchmarks in pthread-wmm #1292

Open
hernanponcedeleon opened this issue Feb 4, 2021 · 0 comments
Open

"Repeated" benchmarks in pthread-wmm #1292

hernanponcedeleon opened this issue Feb 4, 2021 · 0 comments
Labels
C Task in language C duplicate

Comments

@hernanponcedeleon
Copy link
Contributor

Half of the benchmarks in this folder are tagged *.opt and half *.oepc.
According to the README these are two optimisations to minimise the amount of instrumentation.
These benchmarks were probably generated automatically and thus there were always two versions.
However, after inspection, MANY of the benchmarks only differ in the pthread_id, e.g.

diff safe010_power.opt.c safe010_power.oepc.c
209,212c209,212
<   pthread_t t2011;
<   pthread_create(&t2011, NULL, P0, NULL);
<   pthread_t t2012;
<   pthread_create(&t2012, NULL, P1, NULL);
---
>   pthread_t t2009;
>   pthread_create(&t2009, NULL, P0, NULL);
>   pthread_t t2010;
>   pthread_create(&t2010, NULL, P1, NULL);

and thus such benchmarks can be considered duplicated.
I'm planning to make a PR removing these duplications, but before going to the pain of this work, I wanted to be sure this would be the actions to be taken.

@hernanponcedeleon hernanponcedeleon added duplicate C Task in language C labels Feb 4, 2021
maul-esel pushed a commit to ultimate-pa/sv-benchmarks that referenced this issue Oct 14, 2021
Eliminate "repeated" benchmarks in pthread-wmm

Closes sosy-lab#1292

See merge request sosy-lab/benchmarking/sv-benchmarks!1312
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C Task in language C duplicate
Development

No branches or pull requests

1 participant