This repository has been archived by the owner on Oct 3, 2021. It is now read-only.
Update coverage properties #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore versatile script Simplify large parts of the script used to create C files and sv-benchmarks task definitions from XCSP3 task definitions. Include binary for ./xcsp3_cpp_parser to avoid the manual step of cloning the corresponding repository and building the binary.
Properly format assert(0)-changes, as well - this is implied by the necessary formatting of the benchmark tasks and can't be solved in an easy way
Original version does not correctly convert constraint-solving problems with extensional constraints that are declared as conflicts
|
@skanav would you mind having a look at this PR? |
|
Possible additional optional idea:
|
According to XCSP, these are open problems. But we claim that they are safe (CPAchecker and CBMC report TRUE for most of them)
…-call
Over the course of the last year, a lot of tasks were fixed and a a lot of tasks were added.
Most of the time, people did not consider the coverage-* properties for these tasks, so let's add
them now.
Properties are added according to the criteria stated in !842:
* Compiles, if __VERIFIER_X method definitions are provided,
* No termination property or expected verdict for termination is true, and
* Some _VERIFIER_nondet* method exists that is not only declared, but used in at least one other location
Compliance is checked and properties are added with the scripts found at
https://gist.github.com/lembergerth/1a1bf782931fb16af0d9e4bc1085a737 .
Ability to compile is checked with `bin/prtest --compile-only`,
PRTest version
https://gitlab.com/sosy-lab/software/prtest/-/tree/cc9cc249
lembergerth
force-pushed
the
update-coverage-properties
branch
from
1193b08 to
db044b7
Compare
|
@kfriedberger or @skanav This PR is ready for review. |
|
Looks good. |
skanav
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This PR was rebased against #1202 to get the correct XCSP verdicts.]
Over the course of the last year, a lot of tasks were fixed and a a lot of tasks were added.
Most of the time, people did not consider the coverage-* properties for these tasks, so let's add
them now.
Properties are added according to the criteria stated in #842:
Compliance is checked and properties are added with the scripts found at
https://gist.github.com/lembergerth/1a1bf782931fb16af0d9e4bc1085a737 .
Ability to compile is checked with
bin/prtest --compile-only,PRTest version https://gitlab.com/sosy-lab/software/prtest/-/tree/cc9cc249