Async nonblocking fileio #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.x.x #597 +/- ##
==========================================
- Coverage 80.41% 80.40% -0.01%
==========================================
Files 77 77
Lines 6465 6467 +2
==========================================
+ Hits 5199 5200 +1
- Misses 1266 1267 +1 ☔ View full report in Codecov by Sentry. |
adam-fowler
force-pushed
the
async-nonblocking-fileio
branch
2 times, most recently
from
b30be93
to
515e7df
Compare
Also remove exposing EventLoopGroup in AWSClient as it is no longer needed
adam-fowler
force-pushed
the
async-nonblocking-fileio
branch
from
515e7df
to
1a059d2
Compare
0xTim
approved these changes
Mar 30, 2024
adam-fowler
added a commit
that referenced
this pull request
Apr 5, 2024
adam-fowler
added a commit
that referenced
this pull request
Apr 10, 2024
adam-fowler
added a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use async versions of NonBlockingFileIO functions from NIOPosix.
Waiting for SwiftNIO release
Converted everything to NIOFileSystem, but since that still hasn't had a proper release going back to NonBlockingFileIO