Fix: Use unique key for S3Files for folder copy progress #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older from S3 When copying or syncing a folder from S3 to local, it was using S3File.name to calculate total size for progress. S3File.name will not be unique if there are two or more files with the same filename in different subfolders.
|
In release 0.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying a folder from S3 to local, in
copy(from s3Folder: S3Folder, to folder: String...)FolderUploadProgress's init was using S3File.name to calculate total size of all the files. S3File.name will not be unique if there are two or more files with the same filename in different subfolders. For example if you tried to download this folder from S3 it would assertassert(folderProgress.finished == true):