Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] aact-based Based Agent #221

Merged
merged 68 commits into from
Oct 14, 2024
Merged

[Experimental] aact-based Based Agent #221

merged 68 commits into from
Oct 14, 2024

Conversation

ProKil
Copy link
Member

@ProKil ProKil commented Oct 8, 2024

The first step of #188: Implementing an aact-based BaseAgent.

πŸ“‘ Description

A new BaseAgent class using aact's Node API. Please check out examples and doc for usage

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

β„Ή Additional Information

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 95.29412% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.88%. Comparing base (78a8c27) to head (7c467d7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tests/experimental/test_agent.py 93.02% 3 Missing ⚠️
sotopia/experimental/agents.py 97.50% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   72.22%   72.88%   +0.65%     
==========================================
  Files          55       58       +3     
  Lines        2888     2972      +84     
==========================================
+ Hits         2086     2166      +80     
- Misses        802      806       +4     
Files with missing lines Coverage Ξ”
sotopia/envs/parallel.py 77.71% <ΓΈ> (-0.13%) ⬇️
sotopia/experimental/__init__.py 100.00% <100.00%> (ΓΈ)
sotopia/renderers/xml_renderer.py 92.10% <ΓΈ> (-0.21%) ⬇️
sotopia/experimental/agents.py 97.50% <97.50%> (ΓΈ)
tests/experimental/test_agent.py 93.02% <93.02%> (ΓΈ)

... and 1 file with indirect coverage changes

@ProKil ProKil requested a review from XuhuiZhou October 12, 2024 01:09
@ProKil ProKil changed the title [Experimental] Integrating aact into Sotopia [Experimental] aact-based Based Agent Oct 14, 2024
@ProKil ProKil merged commit 080a17b into main Oct 14, 2024
9 checks passed
@ProKil ProKil deleted the feature/integrate-aact branch October 14, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants