-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customizable evaluation dimensions #256
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4e78730
add customizable evaluation dimensions
bugsz 974cd88
add docs
XuhuiZhou 4355c79
fix mypy error & refactor examples
bugsz 6e5754b
add docs for evaluation dimensions
bugsz 0368a0c
update docs and examples
bugsz fd1e984
add test cases and fix mypy issue
bugsz 6155292
fix mypy issue
bugsz e9f1cd9
Fix test_create_custom_dimension to use CustomEvaluationDimension.get…
XuhuiZhou 135effb
Fix/custom eval dimension test (#263)
XuhuiZhou 24c1fb1
add doc
XuhuiZhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
## Overview | ||
|
||
Evaluation dimensions are used to evaluate the quality of social interactions. | ||
In original Sotopia paper, there are 7 dimensions to evaluate the quality of social interactions, where we named them as `sotopia` evaluation dimensions: | ||
- believability | ||
- relationship | ||
- knowledge | ||
- secret | ||
- social rules | ||
- financial and material benefits | ||
- goal | ||
|
||
The `SotopiaDimensions` can be used directly without initializing the database. It provides a set of predefined evaluation dimensions that are ready to use for evaluating social interactions. For example, | ||
|
||
```python | ||
from sotopia.envs.parallel import ParallelSotopiaEnv | ||
from sotopia.envs.evaluators import EvaluationForTwoAgents, ReachGoalLLMEvaluator, RuleBasedTerminatedEvaluator, SotopiaDimensions | ||
|
||
env = ParallelSotopiaEnv( | ||
env_profile=env_profile, | ||
model_name=model_names["env"], | ||
action_order="round-robin", | ||
evaluators=[ | ||
RuleBasedTerminatedEvaluator(max_turn_number=20, max_stale_turn=2), | ||
], | ||
terminal_evaluators=[ | ||
ReachGoalLLMEvaluator( | ||
model_names["env"], | ||
EvaluationForTwoAgents[SotopiaDimensions], # type: ignore | ||
# TODO check how to do type annotation | ||
), | ||
], | ||
) | ||
``` | ||
|
||
|
||
However we observe under many use cases people may want to evaluate with customized evaluation metrics, so we provide a way to build custom evaluation dimensions. | ||
For a quick reference, you can directly check out the `examples/use_custom_dimensions.py`. | ||
|
||
### CustomEvaluationDimension | ||
The [`CustomEvaluationDimension`](/python_API/database/evaluation_dimensions) is a class that can be used to create a custom evaluation dimension. | ||
There are four parameters: | ||
- name: the name of the dimension | ||
- description: the description of the dimension | ||
- range_low: the minimum score of the dimension (should be an integer) | ||
- range_high: the maximum score of the dimension (should be an integer) | ||
|
||
### CustomEvaluationDimensionList | ||
The [`CustomEvaluationDimensionList`](/python_API/database/evaluation_dimensions) is a class that can be used to create a custom evaluation dimension list based on the existing dimensions. It helps one to group multiple dimensions together for a specific use case. | ||
There are two parameters: | ||
- name: the name of the dimension list | ||
- dimension_pks: the primary keys of the dimensions in the dimension list | ||
|
||
### EvaluationDimensionBuilder | ||
The [`EvaluationDimensionBuilder`](/python_API/database/evaluation_dimensions) is a class that can be used to generate a custom evaluation dimension model based on the existing dimensions. | ||
|
||
|
||
## Usage | ||
### Initialize the database | ||
The default evaluation metric is still `SotopiaDimensions` in `sotopia.env.evaluators`.There is no `CustomEvaluationDimension` in the database by default. To initialize the database, please refer to `examples/use_custom_dimensions.py`. | ||
|
||
|
||
### Use the custom evaluation dimensions | ||
After you initialize your customized evaluation dimensions, you can choose to use any one of these methods provided below: | ||
|
||
#### Method 1: Choose dimensions by names | ||
```python | ||
evaluation_dimensions = ( | ||
EvaluationDimensionBuilder.select_existing_dimension_model_by_name( | ||
["transactivity", "verbal_equity"] | ||
) | ||
) | ||
``` | ||
|
||
#### Method 2: Directly choose the grouped evaluation dimension list | ||
```python | ||
evaluation_dimensions = ( | ||
EvaluationDimensionBuilder.select_existing_dimension_model_by_list_name( | ||
"sotopia" | ||
) | ||
) | ||
``` | ||
|
||
#### Method 3: Build a custom evaluation dimension model temporarily | ||
We provide multiple ways to build a custom evaluation dimension model with `EvaluationDimensionBuilder`, specifically: | ||
- `generate_dimension_model`: build an evaluation dimension from existing dimension primary keys. | ||
- `generate_dimension_model_from_dict`: build an evaluation dimension from a dictionary that specifies the parameters of the `CustomEvaluationDimension`. For example | ||
```json | ||
[ | ||
{ | ||
"name": "believability", | ||
"description": "The believability of the interaction", | ||
"range_low": 0, | ||
"range_high": 10 | ||
}, | ||
... | ||
] | ||
``` | ||
- `select_existing_dimension_model_by_name`: build an evaluation dimension from existing dimension names. For example `['believability', 'goal']` | ||
- `select_existing_dimension_model_by_list_name`: build an evaluation dimension from existing `CustomEvaluationDimensionList` list names. For example, directly use `sotopia`. | ||
|
||
|
||
After you get the evaluation dimension model, you can pass it as a parameter for the `Evaluator`, for example, | ||
```python | ||
evaluation_dimensions = ( | ||
EvaluationDimensionBuilder.select_existing_dimension_model_by_list_name( | ||
"sotopia" | ||
) | ||
) | ||
terminal_evaluators=[ | ||
ReachGoalLLMEvaluator( | ||
model_names["env"], | ||
EvaluationForTwoAgents[evaluation_dimensions], # type: ignore | ||
), | ||
], | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# `evaluation_dimensions.py` | ||
|
||
This module provides classes and utilities for defining and managing custom evaluation dimensions within the Sotopia environment. It includes classes for individual dimensions, lists of dimensions, and a builder for creating dimension models. | ||
|
||
## Classes | ||
|
||
### `CustomEvaluationDimension` | ||
|
||
Represents a custom evaluation dimension with specific attributes such as name, description, and score range. | ||
|
||
#### Attributes | ||
- `name`: `str`. The name of the dimension. | ||
- `description`: `str`. A brief description of the dimension. | ||
- `range_low`: `int`. The minimum score for the dimension. | ||
- `range_high`: `int`. The maximum score for the dimension. | ||
|
||
### `CustomEvaluationDimensionList` | ||
|
||
Groups multiple custom evaluation dimensions together. | ||
|
||
#### Attributes | ||
- `name`: `str`. The name of the dimension list. | ||
- `dimension_pks`: `list[str]`. A list of primary keys for the dimensions included in the list. | ||
|
||
### `EvaluationDimensionBuilder` | ||
|
||
Provides utility methods to create and manage evaluation dimension models. | ||
|
||
#### Methods | ||
- `create_range_validator(low: int, high: int)`: Creates a validator for score ranges. | ||
|
||
**Arguments:** | ||
- `low`: `int`. The minimum score allowed. | ||
- `high`: `int`. The maximum score allowed. | ||
|
||
- `build_dimension_model(dimension_ids: list[str])`: Builds a dimension model from primary keys. | ||
|
||
**Arguments:** | ||
- `dimension_ids`: `list[str]`. A list of dimension primary keys. | ||
|
||
- `build_dimension_model_from_dict(dimensions: list[dict[str, Union[str, int]]])`: Builds a dimension model from a dictionary. | ||
|
||
**Arguments:** | ||
- `dimensions`: `list[dict[str, Union[str, int]]]`. A list of dictionaries specifying dimension attributes. | ||
|
||
- `select_existing_dimension_model_by_name(dimension_names: list[str])`: Selects a dimension model by dimension names. | ||
|
||
**Arguments:** | ||
- `dimension_names`: `list[str]`. A list of dimension names. | ||
|
||
- `select_existing_dimension_model_by_list_name(list_name: str)`: Selects a dimension model by list name. | ||
|
||
**Arguments:** | ||
- `list_name`: `str`. The name of the dimension list. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure mention they can use
SotopiaDimension
here as well, and people don't need to initialize the database when using that