Deploy the api to modal #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 74.47% 70.36% -4.12%
==========================================
Files 61 64 +3
Lines 3162 3664 +502
==========================================
+ Hits 2355 2578 +223
- Misses 807 1086 +279
|
ProKil
requested changes
Dec 13, 2024
sotopia/ui/modal_api_server.py
Outdated
| "apt-get install -y redis-stack-server", | ||
| ) | ||
| .pip_install( | ||
| "pydantic>=2.5.0,<3.0.0", |
There was a problem hiding this comment.
Why not just install sotopia? This is not useful for maintaining dependencies.
XuhuiZhou
requested changes
Dec 14, 2024
@ProKil Current |
- Added a new script for the modal API server that initializes a Redis instance. - Created a persistent volume for Redis data and included a function to download initial data if not present. - Configured a Docker image with necessary dependencies including Redis Stack and FastAPI. - Implemented a web API class that sets up and cleans up the Redis connection, ensuring readiness before serving requests. - Integrated the SotopiaFastAPI application within the modal framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr majorly
modal_api_serverCloses #
π Description
β Checks
type/descript(e.g.feature/add-llm-agents)βΉ Additional Information