-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lattice support #2438
Merged
Merged
Lattice support #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentin
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First quick read.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2438 +/- ##
==========================================
+ Coverage 77.75% 78.00% +0.24%
==========================================
Files 474 483 +9
Lines 31164 31999 +835
==========================================
+ Hits 24232 24961 +729
- Misses 6932 7038 +106
|
quentin
approved these changes
Nov 15, 2023
Great feature and impressive work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for lattice elements in Soufflé, in a similar way as the Flix language (see https://flix.dev/ and in particular this paper )
Given a type named
myType
declared with.type myType = ...
, one can now attach a lattice description for this type in the form :Now, one can declare a relation with lattice arguments :
Semantically, a tuple R(x,y,z) where z is a lattice element implies all tuples R(x,y,z') where z' <= z is the lattice.
Additionally, such relation R will ensure at each time that there is a single fact of the form
R(x, y, ...)
, and...
will be the least upper bound (using the Lub specification of the lattice) of all the otherwise produced tuples of the formR(x, y, ...)
.Clauses using atoms containing lattice attributes will behave accordingly to the semantics of lattice:
Example:
will produce the fact
A($Positive())
because the factTop($Top())
impliesTop($Positive())
($Positive() < $Top()
in the lattice). Technically, x will be evaluated as the the GLB of the x inPos(x)
and the x inTop(x)
.Note that it is still possible to use the type
myType
as is without the lattice description :and the relation R will behave as a regular relation, without automatic lub/glb.
See test interface/lub for a few examples using lattice
For the time being, there is a restriction on the Lub and Glb definitions : they can only be user-defined functors with the right signature. This can be extended in future PRs.