Allow to init Saxerator::Builder::HashElement without arguments #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulcutter
added a commit
that referenced
this pull request
Feb 2, 2015
Allow to init Saxerator::Builder::HashElement without arguments
|
I suspect that this will not be needed later on when we stop subclassing |
|
Also worth noting that the params you pass into this object have different meaning than what you'd pass into a |
|
@soulcutter thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is a rare case with serialize method from
ActiveRecord.When I'm trying to use
Saxerator::Builder::HashElementthrough this serialization it raises an error about wrong number of arguments (0 for 2).Can we save the same
initializemethod's behavior as a behavior of parent class?To be able to use
Saxerator::Builder::HashElement.newlikeHash.new