Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes stream to implement the Readable interface #124

Closed
wants to merge 1 commit into from

Conversation

heygambo
Copy link

MockFirestoreQuery.prototype.stream was using the underlying EventEmitter to emit the events which bypassed the stream's logic.

This PR changes it to return a Transformable stream.

That will make stream reader functions available like stream.pause(), stream.resume() or stream.read().

The existing tests pass.

MockFirestoreQuery.prototype.stream now returns a Transform stream.
That will make the stream pausable and resumable.
@dmurvihill
Copy link

Thanks for the contribution, @heygambo. I don't know if you still rely on firebase-mock or not, but we're moving activity over to my fork for now (see #160) and will be reviewing this for an early December release. Cheers.

New PR on the interim repo

@heygambo
Copy link
Author

Awesome. Yes, we still use it.
Thanks for taking care of that!

@dmurvihill
Copy link

My pleasure. If you've made any changes on your own fork besides this one, a pull request would be welcome. Opening before next Thursday (U.S. Thanksgiving) would give the best chance of getting into the release.

Also, we are looking for maintainers.

@heygambo
Copy link
Author

@dmurvihill hey this can be closed here right?

@dmurvihill
Copy link

Yes, go ahead and close it. If you want the new change, update your package.json to "firebase-mock": "^2.3.0".

@heygambo heygambo closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants