Add code coverage automation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-290 Manual test coverage analysis and next steps
evaluate test coverage and propose unit + integration tests to add |
🦋 Changeset detectedLatest commit: 7dd9102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elenadimitrova
force-pushed
the
elena/pro-290-manual-test-coverage-analysis-and-next
branch
2 times, most recently
from
1b8ec4a
to
6733821
Compare
elenadimitrova
force-pushed
the
elena/pro-290-manual-test-coverage-analysis-and-next
branch
from
6733821
to
0c7d3b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
Coverage ? 85.62%
=========================================
Files ? 7
Lines ? 160
Branches ? 28
=========================================
Hits ? 137
Misses ? 4
Partials ? 19 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elenadimitrova
force-pushed
the
elena/pro-290-manual-test-coverage-analysis-and-next
branch
from
303b8aa
to
7dd9102
Compare
vigneshka
approved these changes
Aug 17, 2022
gigamesh
approved these changes
Aug 17, 2022
elenadimitrova
deleted the
elena/pro-290-manual-test-coverage-analysis-and-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code coverage using
forge coverageand lcov reports. Reports are uploaded to codecov.Also consolidated invariant tests into a dedicated folder for clarity.
Note that even though code coverage reports are theoretically "working" these are still experimental in foundry and so far I have found discrepancies in branch evaluation, i.e. all
ifbranches are reported as partially code covered even though there are fully covered branches in our tests. Bottom line is always double check the report against tests untilforge coverageis stabilised.For reference overall forge coverage backlog is maintained in foundry-rs/foundry#1961