-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node)!: drop support for Node.js 12, Node.js 15, and Node.js 17 #427
Draft
sounisi5011
wants to merge
18
commits into
main
Choose a base branch
from
node-version/drop-support-v12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js 12 has reached the end-of-life. This project will support Node.js v14.19 or later from now on. The reason for Node.js v14.19 is that it is the [smallest version supported by pnpm v7](https://github.com/pnpm/pnpm/releases/tag/v7.0.0).
+ Node.js 15 is no longer supported after 2021-06-01 + Node.js 17 will no longer be supported after 2022-06-01
…/*` and `n/no-unsupported-features/*` rules
…sion to 16 for executing actions
…only supported versions I don't see any particular significance in this change, but I am a stickler for details.
To the future editor: I used the following command to find the Node.js version string contained within this repository. git grep -F 12 -- ':(exclude,glob)**/dist/**' ':(exclude,glob)**/pnpm-lock.yaml' ':(exclude,glob)**/*.svg' ':(exclude,glob)**/__snapshots__/**' ':(exclude,glob)**/*.md'
git grep -F 12 -- ':(exclude,glob)**/dist/**' ':(exclude,glob)**/pnpm-lock.yaml' ':(exclude,glob)**/*.svg' ':(exclude,glob)**/__snapshots__/**' ':(exclude,glob)**/CHANGELOG.md'
git grep -E '15|17' -- ':(exclude,glob)**/dist/**' ':(exclude,glob)**/pnpm-lock.yaml' ':(exclude,glob)**/*.svg' ':(exclude,glob)**/__snapshots__/**' ':(exclude,glob)**/*.md'
git grep -E '15|17' -- ':(exclude,glob)**/dist/**' ':(exclude,glob)**/pnpm-lock.yaml' ':(exclude,glob)**/*.svg' ':(exclude,glob)**/__snapshots__/**' ':(exclude,glob)**/CHANGELOG.md' |
This was referenced May 28, 2022
Starting with pnpm v7.2.1, Node.js 14.6 or later is now supported. https://github.com/pnpm/pnpm/releases/tag/v7.2.1
Code Climate has analyzed commit 3d9be61 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 12 and Node.js 15 has reached the end-of-life. Also, soon Node.js 17 will reach end-of-life.
This project will support Node.js v14.6 or later from now on.
The reason for Node.js v14.6 is that it is the minimum version supported by pnpm v7.2.1 or later.