-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distance_calculator #531
base: main
Are you sure you want to change the base?
Conversation
@souravjain540 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works for positive integers but doesn't accept negative points (ex: (-2,0)). In addition, there should be a way to break out of the while loop, such as inputting a sentinel value.
Ok I will try to fix it, and thanks for telling 👍 Edit: I fixed the bug and it was actually really easy. I just replaced every |
Fixed a bug where negative numbers were not allowed and added a quit features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Made the calculator compatible with floating(decimal)numbers
Thanks! I also fixed a bug where decimal numbers were incompatible. |
I'd like to add a distance calculation program i made