Skip to content

Commit

Permalink
Merge branch 'master' into feat/show-bonus-xp-end-date
Browse files Browse the repository at this point in the history
  • Loading branch information
RichDom2185 committed Aug 23, 2024
2 parents 214ba85 + 9723ec3 commit 7330aac
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions lib/cadet/assessments/assessments.ex
Original file line number Diff line number Diff line change
Expand Up @@ -2387,7 +2387,7 @@ defmodule Cadet.Assessments do
def update_grading_info(
%{submission_id: submission_id, question_id: question_id},
attrs,
%CourseRegistration{id: grader_id}
cr = %CourseRegistration{id: grader_id}
)
when is_ecto_id(submission_id) and is_ecto_id(question_id) do
attrs = Map.put(attrs, "grader_id", grader_id)
Expand All @@ -2409,16 +2409,23 @@ defmodule Cadet.Assessments do
submission =
Submission
|> join(:inner, [s], a in assoc(s, :assessment))
|> preload([_, a], assessment: a)
|> preload([_, a], assessment: {a, :config})
|> Repo.get(submission_id)

is_grading_auto_published = submission.assessment.config.is_grading_auto_published

with {:answer_found?, true} <- {:answer_found?, is_map(answer)},
{:status, true} <-
{:status, answer.submission.status == :submitted or is_own_submission},
{:valid, changeset = %Ecto.Changeset{valid?: true}} <-
{:valid, Answer.grading_changeset(answer, attrs)},
{:ok, _} <- Repo.update(changeset) do
update_xp_bonus(submission)

if is_grading_auto_published and is_fully_graded?(submission_id) do
publish_grading(submission_id, cr)
end

{:ok, nil}
else
{:answer_found?, false} ->
Expand Down

0 comments on commit 7330aac

Please sign in to comment.