Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token divider field to contest voting XML file #1034

Merged
merged 47 commits into from
Dec 8, 2023

Conversation

kjw142857
Copy link
Contributor

@kjw142857 kjw142857 commented Nov 8, 2023

This pull request aims to allow educators to specify the divider for the token penalty applied when contest entries are scored. The divider will be specified in the contest XML file under the token_divider field, which is compulsory and will be parsed by the XML parser before later being referenced when calculating the formula score. If the token_divider field is not specified or is <= 0, the BE will not allow the XML contest voting file to be uploaded.

Note: The smaller the token divider, the larger the penalty that will be applied for long programs. For most purposes, setting the token divider in the range 50-100 should be sufficient.

@coveralls
Copy link

coveralls commented Nov 8, 2023

Coverage Status

coverage: 95.288% (+0.004%) from 95.284%
when pulling 744afd4 on kjw142857:master
into df78afa on source-academy:master.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, LGTM!

Thanks a lot, this will definitely be very helpful to minimise redeployments when the denominator needs to change.

@RichDom2185 RichDom2185 merged commit 3b35b80 into source-academy:master Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants