Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Popular Vote Leaderboard #1066

Merged
merged 10 commits into from
Feb 24, 2024
Merged

Display Popular Vote Leaderboard #1066

merged 10 commits into from
Feb 24, 2024

Conversation

DesSnowy
Copy link
Contributor

Description
This pull request supports the usage of a new tab which shows the popular votes leaderboard in the contest voting assessments. Relevant frontend pull request has been opened.

Changes To Be Made

  • Added new popular_score field to answers
  • Added new methods which mirrors calculation for relative_score to popular_score
  • Added new popularVoteLeaderboard output for voting questions
  • Changed testcases to include popularVoteLeaderboard

@jayjay19630 jayjay19630 mentioned this pull request Feb 17, 2024
Merged
4 tasks
@jayjay19630
Copy link
Contributor

Corresponding frontend PR: source-academy/frontend#2785

@coveralls
Copy link

coveralls commented Feb 18, 2024 •
edited
Loading

Coverage Status

coverage: 94.992% (+0.05%) from 94.943%
when pulling b6b94f6 on DesSnowy:PopularVoteContest
into 3135f48 on source-academy:master.

RichDom2185
RichDom2185 reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delayed review. Thanks for working on this, I just have one comment below:

lib/cadet/assessments/assessments.ex Show resolved Hide resolved
RichDom2185
RichDom2185 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 11154a6 into source-academy:master Feb 24, 2024
2 checks passed
@DesSnowy DesSnowy deleted the PopularVoteContest branch February 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

@sayomaki sayomaki Awaiting requested review from sayomaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DesSnowy @jayjay19630 @coveralls @RichDom2185