Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug causing build_user_filter to filter incorrectly. #1072

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Fix bug causing build_user_filter to filter incorrectly. #1072

merged 2 commits into from
Feb 25, 2024

Conversation

GabrielCWT
Copy link
Contributor

  • Changed build_user_filter to use correct table. student_id in Submissions refers to the Course Reg ID, not the User ID.

@GabrielCWT
fix: Fix bug causing build_user_filter to filter incorrectly.
7d3f9b6 
student_id in Submissions refers to the Course Reg ID, not the User ID.
@coveralls
Copy link

coveralls commented Feb 24, 2024 •
edited
Loading

Coverage Status

coverage: 94.958% (-0.03%) from 94.992%
when pulling 268b360 on GabrielCWT:fix/submissions-filter
into 11154a6 on source-academy:master.

RichDom2185
RichDom2185 approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 749c544 into source-academy:master Feb 25, 2024
2 checks passed
@GabrielCWT GabrielCWT deleted the fix/submissions-filter branch February 25, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabrielCWT @coveralls @RichDom2185