-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LLM improvements #1144
Merged
Merged
Add LLM improvements #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RichDom2185
commented
Aug 4, 2024
•
edited by yiwen101
Loading
edited by yiwen101
- Access control
- Logging & auditing
- Move prompt generation to BE to prevent bypass
Only contains some migrated data at the moment.
yiwen101
force-pushed
the
llm-improvements
branch
2 times, most recently
from
August 4, 2024 07:27
7d40dd7
to
a961e38
Compare
@yiwen101 the prompt builder is separated from SICP notes so that we can put AG logic inside the builder and retain the abstraction |
RichDom2185
commented
Aug 4, 2024
RichDom2185
force-pushed
the
llm-improvements
branch
from
August 4, 2024 08:08
1a1403f
to
937cd3b
Compare
* Rename query to context for clarity * Add missing alias and documentation
* Set context size limit * Fix update issue * Fix write issue * Fix parse issue
…backend into llm-improvements
yiwen101
force-pushed
the
llm-improvements
branch
from
August 10, 2024 18:01
c341920
to
742f24e
Compare
yiwen101
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
Corresponding FE PR: source-academy/frontend#3010 |
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.