Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create endpoint for retrieval of all assessment submissions #1210

Merged

Conversation

josh1248
Copy link
Contributor

@josh1248 josh1248 commented Nov 13, 2024

Frontend PR: source-academy/frontend#3076
Branched from #1180

Creates an endpoint that obtains all assessments submitted without any filter or pagination. Admin-only endpoint.

@coveralls
Copy link

coveralls commented Nov 13, 2024

Coverage Status

coverage: 93.605% (-0.06%) from 93.661%
when pulling 85c0500 on GabrielCWT:all-submissions-endpoint
into 5203125 on source-academy:master.

@josh1248 josh1248 force-pushed the all-submissions-endpoint branch from 9f7b6f3 to 4b03ad8 Compare November 13, 2024 15:09
@RichDom2185 RichDom2185 force-pushed the all-submissions-endpoint branch from 2f67e42 to b4ff325 Compare November 16, 2024 11:42
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

conn,
%{
"group" => "false",
"pageSize" => "100000000000",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha sure, maybe in the future we can filter by assessment name (it's a use case for the PA because we export the grades to Canvas separately).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, that would be a good future change to generalize the export function!

@@ -26,7 +26,7 @@ alias Cadet.Accounts.{
# Cadet.Repo.insert!(%Cadet.Settings.Sublanguage{chapter: 1, variant: "default"})

if Cadet.Env.env() == :dev do
number_of_students = 100_000
number_of_students = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is reduced again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was taking too long to reset the db :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof 😢 ok maybe we will see how then, we can change it back later haha

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I think we can put it to 1000 to mimic 1101S?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, 1000 would be good! doesnt take too long for a one time set up (at most a minute).

@RichDom2185 RichDom2185 merged commit b406ab0 into source-academy:master Nov 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants