Add Avenger Backlog Notifications #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Notifications module and NotificationType model - Start migration for adding notifications - No functionalities added yet only template code
notification entry
Changes: * Replaced is_enable to is_enabled for Notification Preferences * Update default is_enabled to true for Notifcation Types
`import_config` must always appear at the bottom for environment specific configurations to be applied correctly. All configurations after this line will overwrite configurations that exists in the environment specific ones.
- remove auto-generated controllers and views that are not used
If user preference has no time option, use the time_option from notification_config instead. This is so that the behaviour of these users with no preferences would always follow the default chosen by the course admin
…/Santosh3007/source-academy-backend into add-avenger-backlog-notification
…/Santosh3007/source-academy-backend into add-avenger-backlog-notification
Current nus users will have their email attribute populated based on their username. nus users are identified from the provider attribute. Future nus users will have their email attribute populated on creation ideally.
- move mailing logic to notification worker - insert into sent_notifications when email is sent out successfully
- move guard clauses to prevent unnecessary querying
chownces
approved these changes
Mar 27, 2023
|
|
||
| <p> There is a new submission by <%= @student_name %> for <a href="/"><%= @assessment_title %></a>. Please Review and grade the <a href="/">submission </a></p> | ||
|
|
||
| <a href="/">Unsubscribe</a> from this email topic. |
|
|
||
| """ | ||
|
|
||
| # def list_sent_notifications do |
There was a problem hiding this comment.
would these commented out functions be used in the future?
This was referenced May 25, 2023
|
Let us merge this first so that this can be tested on staging. The remaining issues seem to be minor, and I have created issues as above to be resolved. |
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source Academy Notifications
This is the first iteration of introducing notifications into Source Academy. Currently, this introduces two notification types:
Avenger Backlog,Assessment Submissionand only through the email medium.In future iterations, more notifications can be included and other mediums of notifications can be explored.
Changes
Notes
notificationstable is left untouched for nownotification_configswhen new courses are insert & when new assessments are createdemailcolumn inuserstable usingusername(Only for NUS users where the provider is luminus)