Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP3108 Staff Dashboard - Avengers Leaderboard #1069

Merged
merged 13 commits into from
May 19, 2020

Conversation

Wong-ZZ
Copy link
Contributor

@Wong-ZZ Wong-ZZ commented Apr 14, 2020

Context

This PR adds the Avengers Leaderboard component for the CP3108 Staff Dashboard project. The Avengers Leaderboard keeps track of the grading progress of each avenger in the course and displays the total number of ungraded/submitted missions/quest of each avenger

Implementation

  • The Avengers Leaderboard is accessible through the Dashboard tab in the navigation bar and can only be accessed by staffs/admin.
  • Added a new request method to fetch the overview of all the groups. The overview contains the group id, group name and the name of the the group's avenger.
  • Added a new redux state to store the group overviews

The UI for the Avengers Leaderboard can be seen here:
Capture

Other Information

Corresponding PR to cadet: PR 582
More info in the wiki: Avengers Leaderboard

@coveralls
Copy link

coveralls commented Apr 14, 2020

Pull Request Test Coverage Report for Build 4863

  • 40 of 93 (43.01%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 37.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/containers/dashboard/DashboardContainer.ts 8 9 88.89%
src/mocks/backend.ts 2 3 66.67%
src/sagas/requests.ts 1 7 14.29%
src/components/dashboard/Dashboard.tsx 6 51 11.76%
Totals Coverage Status
Change from base Build 4858: -0.04%
Covered Lines: 2898
Relevant Lines: 6977

💛 - Coveralls

@martin-henz
Copy link
Member

Can you put the description above into a wiki page in cadet frontend?

@Wong-ZZ
Copy link
Contributor Author

Wong-ZZ commented Apr 14, 2020

I have added the information for the Avengers Leaderboard in the wiki page. I will also be updating the other parts of the wiki page overtime since we are still making some changes to the components.

On top of that, I have made another commit that contains the tests for the Avengers Leaderboard.

Copy link

@dearvae dearvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanlowjk seanlowjk merged commit b4fca00 into source-academy:sa_2021 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants