Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP3108 Staff Dashboard - Backend Modifications for Avengers Leaderboard #582

Merged
merged 7 commits into from
May 19, 2020

Conversation

Wong-ZZ
Copy link
Contributor

@Wong-ZZ Wong-ZZ commented Apr 14, 2020

Context

This PR is for modifying the backend API to support the Avengers Leaderboard component for the CP3018 Staff Dashboard project.

The Avengers Leaderboard is meant to track the grading progress of each avenger however, the current grading overview only provides the group name of the student who submitted the assessment and not the avenger's name.

Implementation

Added a GET route to provide an overview of each group in the course. The overview contains the id of the group, the group's name and the name of the group's avenger.

Other Information

Corresponding PR to cadet-frontend: PR1069
More info in the wiki: Avengers Leaderboard

@coveralls
Copy link

coveralls commented May 15, 2020

Pull Request Test Coverage Report for Build 2896

  • 15 of 20 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 91.624%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/cadet_web/controllers/group_controller.ex 5 10 50.0%
Totals Coverage Status
Change from base Build 2893: -0.3%
Covered Lines: 1072
Relevant Lines: 1170

💛 - Coveralls

@angelsl angelsl merged commit 7a04834 into source-academy:sa_2021 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants