Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul grading states design #2522

Open
chownces opened this issue Jun 19, 2023 · 1 comment
Open

Overhaul grading states design #2522

chownces opened this issue Jun 19, 2023 · 1 comment
Labels
Enhancement New feature request good first issue Good for newcomers good project

Comments

@chownces
Copy link
Contributor

chownces commented Jun 19, 2023

The current grading states are insufficient to represent all possible grading states. For example,

Student submits assessment --> avenger grades all questions --> avenger unsubmits assessment (for student to make changes) --> student resubmits

Issues:

  1. After the avenger first grades all questions, the results are immediately shown to the student
  2. When the student resubmits, the assessment is immediately 'Graded' due to point 1 above. This is a source of confusion for both the student and the avenger

Proposal:

  • Introduce additional grading states such as published. Avengers must explicitly publish the grading in order for students to view it
  • During unsubmission, the submission (if already published), will be 'unpublished'
  • Alternatively, we prevent avengers from unsubmitting a submission if it is already published (this means the avenger can only unsubmit in the midst of grading)
  • This 'publish' design is similar to the way Coursemology handles grading

More Context:
On the submission side, there are currently the following states: attempting, attempted and submitted in the database

On the grading side, there are currently the following states: graded, grading, excluded and none. This is currently computed on the frontend under the function computeGradingStatus in RequestsSaga.ts

See: #2189
Might be relevant: #738, #746, #799

image image
@josh1248
Copy link
Contributor

Note to people of the future: the above PR has mostly implemented the suggeestions in this issue, which should make finding resubmitted work much easier. The only thing left is that an assessment will be still marked from "attempted" to "graded" if previously unsubmitted. Could be a good first issue.

@josh1248 josh1248 added the good first issue Good for newcomers label Apr 13, 2024
@josh1248 josh1248 removed their assignment Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature request good first issue Good for newcomers good project
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants