Autocomplete feature #1051
Merged
Autocomplete feature #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add autocompletion and documentation display for builtins
martin-henz
approved these changes
Apr 7, 2020
jonchan51
reviewed
Apr 11, 2020
| score: 1000 // Prioritize suggestions from code | ||
| })); | ||
|
|
||
| const builtinSuggestions = Documentation.builtins[context.chapter] || []; |
There was a problem hiding this comment.
Hi, was looking at the frontend and realised that the variants aren't supported yet.
I took a look and suggest something along the lines of the above. Not sure if there are any consequences of doing that right now though, and whether other variants are able to do something like this.
The inserted code in the screenshot works for Source 3 Concurrent at least, but breaks for Non-Det.
btzy
pushed a commit
that referenced
this pull request
May 2, 2020
* Add autocompletion and documentation display (#2) Add autocompletion and documentation display for builtins * Integrate code autocompletion * Bump js-slang version, handle editor prepend * Comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: