Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Bug fix #1670

Merged
merged 16 commits into from
Mar 29, 2021
Merged

Mobile Bug fix #1670

merged 16 commits into from
Mar 29, 2021

Conversation

YaleChen299
Copy link
Contributor

@YaleChen299 YaleChen299 commented Mar 23, 2021

Description

Fixes:

  • Popover2 arrow bug introduced in Mobile Missions Workspace #1662
  • Handle mobile panel height when the top control bar is rendered in the MobileWorkspace
  • Pre-existing image and pre tag styling issues when SideContentTabs get too narrow
  • Input into AceEditor causing app to scroll to the top on IOS devices
  • Cleaned up user-agent sniffing in MobileWorkspace
  • Added Github ControlBar buttons into the Mobile Playground

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Mar 23, 2021

Pull Request Test Coverage Report for Build 696940162

  • 1 of 23 (4.35%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 28.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/controlBar/ControlBarGitHubButtons.tsx 0 1 0.0%
src/commons/controlBar/ControlBarPersistenceButtons.tsx 0 1 0.0%
src/commons/assessmentWorkspace/AssessmentWorkspace.tsx 1 4 25.0%
src/commons/editor/Editor.tsx 0 8 0.0%
src/commons/mobileWorkspace/MobileWorkspace.tsx 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/commons/controlBar/ControlBarPersistenceButtons.tsx 1 10.53%
src/commons/editor/Editor.tsx 1 7.14%
Totals Coverage Status
Change from base Build 696938685: -0.07%
Covered Lines: 2249
Relevant Lines: 7284

💛 - Coveralls

@martin-henz martin-henz marked this pull request as draft March 25, 2021 01:45
Copy link
Contributor

@chownces chownces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes pre-existing image and pre tag styling issues in SideContentTabs when div gets too narrow. Fixes Popover2 arrow bug in workspace component, which was introduced in #1662

@chownces chownces marked this pull request as ready for review March 27, 2021 09:59
@chownces chownces changed the title Mobile Bug fix (please do not merge yet) Mobile Bug fix Mar 27, 2021
@chownces chownces marked this pull request as draft March 28, 2021 03:22
@chownces
Copy link
Contributor

chownces commented Mar 28, 2021

To add in Github buttons to mobile workspace (which was missed out in the previous Github PR). And handle an editor bug where the app scrolls to the top on input into the editor (on iOS Safari).

@chownces chownces marked this pull request as ready for review March 28, 2021 05:36
@martin-henz martin-henz merged commit 2d59084 into source-academy:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants