Skip to content

Conversation

@samuelfangjw
Copy link
Contributor

Description

text-align-last property is not supported in safari, resulting in hall of fame section not being centrally aligned.

Screenshot 2021-07-20 at 1 02 00 AM

I've fixed the issue by removing the text-align-last property on the p tags, although I have kept it on the description section. This means that the last line of the description will be justified on safari but centered on other browsers.

After screenshots
Chrome:
Screenshot 2021-07-20 at 1 14 35 AM

Safari:
Screenshot 2021-07-20 at 1 14 59 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@samuelfangjw samuelfangjw requested a review from chownces July 19, 2021 17:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1046053456

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 29.957%

Totals Coverage Status
Change from base Build 1044137341: 0.0%
Covered Lines: 3198
Relevant Lines: 9815

💛 - Coveralls

@martin-henz martin-henz merged commit cd982ef into source-academy:master Jul 20, 2021
@samuelfangjw samuelfangjw deleted the fix-contributors-page-safari branch July 28, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants