Skip to content

Grading: Overview filterable buttons onHover Effects #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2024
Merged

Grading: Overview filterable buttons onHover Effects #2782

merged 5 commits into from
Feb 14, 2024

Conversation

@InfinityTwo
Copy link
Contributor

@InfinityTwo InfinityTwo commented Feb 14, 2024 •
edited
Loading

Description

Added an onHover effect to clickable buttons for filters under Grading Overview. Resolves #2497.

  • Buttons with a background will change their contrast values.
  • Buttons without a background will have their text underlined.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  • Open Source Academy and go to Grading
  • Hover over filterable buttons that can be clicked such as "Submitted".

Checklist

  • I have tested this code
  • I have updated the documentation

@InfinityTwo InfinityTwo self-assigned this Feb 14, 2024
@coveralls
Copy link

coveralls commented Feb 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7901293077

Details

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.396%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/grading/subcomponents/GradingBadges.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 7898483488: 0.0%
Covered Lines: 5739
Relevant Lines: 14438
💛 - Coveralls

@InfinityTwo InfinityTwo marked this pull request as ready for review February 14, 2024 12:15
RichDom2185
RichDom2185 reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this! Direction looks good – just a minor clarification below:

RichDom2185
RichDom2185 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) February 14, 2024 12:43
@RichDom2185 RichDom2185 merged commit 8a7e9c0 into source-academy:master Feb 14, 2024
sumomomomomo pushed a commit that referenced this pull request Feb 19, 2024
@InfinityTwo @sumomomomomo
Grading: Overview filterable buttons onHover Effects (#2782)
93e80b6 
* hover effects for filter buttons under grading

* Edited onHover effect background contrast values

* yarn prettier checks

* change from border to text-decoration underline and cleanup code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

@lhw-1 lhw-1 Awaiting requested review from lhw-1

Assignees

@InfinityTwo InfinityTwo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add hover styles to grading tabs

3 participants

@InfinityTwo @coveralls @RichDom2185