CSE Machine: Remove old components and make compact components the default #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e old components. Also removes the experimental button toggle.
|
Is this PR ready @CZX123 ? I got the email for the review but the status is still draft. |
|
Yup, it's ready, was just waiting for the checks first. |
RichDom2185
reviewed
Mar 17, 2024
Comment on lines
12
to
15
| arrayUnit: ReferenceType | ReferenceType; | ||
| referencedBy: (ReferenceType | ReferenceType)[]; | ||
|
|
||
| constructor(referencedBy: ReferenceType[]) { | ||
| constructor(referencedBy: (ReferenceType | ReferenceType)[]) { |
There was a problem hiding this comment.
ReferenceType | ReferenceType is just ReferenceType. Could you clean this up? Thanks!
Comment on lines
132
to
-155
| Layout.values.clear(); | ||
| Layout.compactValues.forEach((v, d) => { | ||
| v.reset(); | ||
| }); | ||
| Layout.compactValues.clear(); |
There was a problem hiding this comment.
Do we not need the .forEach in the new Layout.values anymore?
There was a problem hiding this comment.
Yes, the loop seems to be unnecessary, I'll remove it.
CYX22222003
pushed a commit
that referenced
this pull request
Mar 22, 2024
…fault (#2848) * Make compact components the new default and remove any mentions to the old components. Also removes the experimental button toggle. * Update test snapshots * Clean up testing code a little * Formatting changes * Fix some minor issues
CYX22222003
pushed a commit
that referenced
this pull request
Apr 10, 2024
…fault (#2848) * Make compact components the new default and remove any mentions to the old components. Also removes the experimental button toggle. * Update test snapshots * Clean up testing code a little * Formatting changes * Fix some minor issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the components inside the CSE Machine, such that the compact components are now the default components. Fixes #2845
Changes
compact.Gridcomponent.SideContentCseMachinecomponent.