Restrict conditions to booleans values, for IfStatements and ConditonalExpression #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ning-y
added
Bug
evansb
reviewed
May 26, 2018
| const operatorValues = [num, str, func] | ||
| const context = mockRuntimeContext() | ||
| const errors = operatorValues.map(opVal => rttc.checkIfStatement(context, opVal)) | ||
| errors.map(error => expect(error).toBeDefined()) |
There was a problem hiding this comment.
let's make this check if error is instance of TypeError
evansb
approved these changes
May 26, 2018
ning-y
added a commit
that referenced
this pull request
May 26, 2018
1. Had to make changes to src/mocks/context.ts in order to for the mock Closure to use the Closure constructor (our own typeOf uses typeof, which checks the constructor to determine object types). 2. To get 100% test coverage, there was a need to call the elaborate method of TypeError. Went ahead and replaced that with explain() since it's probably better than 'TODO'. 3. Best way to test the error messages was with snapshots, IMO. Resolves #29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #24 as it uses the convenience function
isBooland test filesrc/slang/utils/__tests__rttc.ts.Summary
a ? b : c;orif (a) { 1; } else { 0; },amust be a boolean value, or a error is raised, and the program is stopped.Issues fixed