Skip to content

Conversation

alsonleej
Copy link
Contributor

Added spread instr to frontend. Resolves #1650.

TODO: animation

@RichDom2185
Copy link
Member

This needs a js-slang update right? aka source-academy/js-slang#1740

@RichDom2185 RichDom2185 added the blocked Something else needs pass review first label Feb 25, 2025
@alsonleej
Copy link
Contributor Author

This needs a js-slang update right? aka source-academy/js-slang#1740

Yes

@RichDom2185 RichDom2185 removed the blocked Something else needs pass review first label Mar 5, 2025
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13667814380

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 31.129%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/cseMachine/CseMachineUtils.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 13667809332: -0.003%
Covered Lines: 4887
Relevant Lines: 14807

💛 - Coveralls

@RichDom2185 RichDom2185 merged commit 4ddb19f into master Mar 5, 2025
8 checks passed
@RichDom2185 RichDom2185 deleted the spreadinstr branch March 5, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants