Sessions Overhaul

[TheMythologist]

Description

CP3108 Project by @salmonkarp and myself
Fixes sessions, as well as better session integration with changes to sessions backend

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Code quality improvements

Linked to source-academy/sharedb-ace#30 and source-academy/sharedb-ace-backend#33

[RichDom2185]

I'm still getting some type errors after linking locally and running yarn build?

[RichDom2185]

Could you explain:

1. The rationale of adding this condition
2. What a better alternative might be

Instead of just "this is bad" please?

[TheMythologist]

@salmonkarp

[salmonkarp]

Think this is a hotfix to disable that navigation bar when I directly paste a URL generated from a session into the address bar. Normally going to the Playground would disable it, but doing so from the generated link didn't. Looking into it.

[salmonkarp]

Changed in recent commit

[TheMythologist]

Hi @RichDom2185 I've fixed the errors, using the solution provided here: reduxjs/redux-toolkit#4900 (comment)

[TheMythologist]

Also, do let me know when the npm package @sourceacademy/sharedb-ace is updated so I can bump the version here

[TheMythologist]

Are there any issues with bumping the @sourceacademy/sharedb-ace npm package? So I can update this PR 👍

Or if there's any other comments to address, do let me know, so we can speed up the addition of this feature!

[RichDom2185]

Are there any issues with bumping the @sourceacademy/sharedb-ace npm package? So I can update this PR 👍

Or if there's any other comments to address, do let me know, so we can speed up the addition of this feature!

Sorry, forgot to update. I don't have access to bump it on NPM. Prof @martin-henz , could you bump it to v2.1.0 as specified in the package.json? No need to increment to 2.1.1, it's already incremented from the PR, just need to publish.

[TheMythologist]

Hi, bumping this @RichDom2185 and prof @martin-henz

[martin-henz]

OK, just published: https://www.npmjs.com/package/@sourceacademy/sharedb-ace

[RichDom2185]

@TheMythologist sorry for the delay, there's still a type error on UseShareAce (even though last I checked using a locally-linked version, everything was fine). Could you check?

[TheMythologist]

Hi, seems like events-emitter-es6 was causing problems. Switched that package for node:events. Created a PR fix here: source-academy/sharedb-ace#32

Let me know once the new package is published, I will bump the version of @sourceacademy/sharedb-ace and hopefully there won't be any more type errors

[TheMythologist]

Hi sorry to bother Prof @martin-henz, but could you help to bump the @sourceacademy/sharedb-ace again? Bump it to 2.1.1 (it's already updated in the package.json file)

[martin-henz]

Hi sorry to bother Prof @martin-henz, but could you help to bump the @sourceacademy/sharedb-ace again? Bump it to 2.1.1 (it's already updated in the package.json file)

OK done.

[TheMythologist]

Sorry prof @martin-henz, requesting you to bump the @sourceacademy/sharedb-ace again one last time, to 2.1.2 (it's already updated in the package.json file).