Skip to content

Sessions Overhaul #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Sessions Overhaul #3140

wants to merge 46 commits into from

Conversation

TheMythologist
Copy link
Contributor

@TheMythologist TheMythologist commented Jun 23, 2025

Description

CP3108 Project by @salmonkarp and myself
Fixes sessions, as well as better session integration with changes to sessions backend

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Linked to source-academy/sharedb-ace#30 and source-academy/sharedb-ace-backend#33

salmonkarp and others added 30 commits February 6, 2025 05:46
…eholder Session Management tab in Playground
@TheMythologist
Copy link
Contributor Author

Note: Packages ace-builds and @testing-library/user-event are updated to fix import errors

@TheMythologist
Copy link
Contributor Author

PR lint test is failing because it is expecting the @sourceacademy/sharedb-ace package to be updated - will update it after the new release has been created

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm still getting some type errors after linking locally and running yarn build?

!Constants.playgroundOnly &&
isEnrolledInACourse &&
!isMobileBreakpoint &&
!window.location.href.includes('/playground/') ? ( //TODO: this is bad
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain:

  1. The rationale of adding this condition
  2. What a better alternative might be

Instead of just "this is bad" please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@salmonkarp salmonkarp Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is a hotfix to disable that navigation bar when I directly paste a URL generated from a session into the address bar. Normally going to the Playground would disable it, but doing so from the generated link didn't. Looking into it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in recent commit

@TheMythologist
Copy link
Contributor Author

Hi @RichDom2185 I've fixed the errors, using the solution provided here: reduxjs/redux-toolkit#4900 (comment)

@TheMythologist
Copy link
Contributor Author

Also, do let me know when the npm package @sourceacademy/sharedb-ace is updated so I can bump the version here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants