-
Notifications
You must be signed in to change notification settings - Fork 172
Sessions Overhaul #3140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sessions Overhaul #3140
Conversation
…eholder Session Management tab in Playground
…/frontend into sessions-overhaul
Note: Packages |
PR lint test is failing because it is expecting the @sourceacademy/sharedb-ace package to be updated - will update it after the new release has been created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!Constants.playgroundOnly && | ||
isEnrolledInACourse && | ||
!isMobileBreakpoint && | ||
!window.location.href.includes('/playground/') ? ( //TODO: this is bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain:
- The rationale of adding this condition
- What a better alternative might be
Instead of just "this is bad" please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is a hotfix to disable that navigation bar when I directly paste a URL generated from a session into the address bar. Normally going to the Playground would disable it, but doing so from the generated link didn't. Looking into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in recent commit
Hi @RichDom2185 I've fixed the errors, using the solution provided here: reduxjs/redux-toolkit#4900 (comment) |
Also, do let me know when the npm package |
Description
CP3108 Project by @salmonkarp and myself
Fixes sessions, as well as better session integration with changes to sessions backend
Type of change
Linked to source-academy/sharedb-ace#30 and source-academy/sharedb-ace-backend#33