Skip to content

persistent feature flags, language and plugin directory support #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 23, 2025
Merged

persistent feature flags, language and plugin directory support #3355

merged 18 commits into from
Sep 23, 2025

Conversation

tsammeow
Copy link
Contributor

@tsammeow tsammeow commented Sep 6, 2025 •
edited
Loading

Description

make feature flags persistent across reloads (localstorage) and add support for language and plugin directory

breaking: reverted language directory to SA version, open a PR to language directory repo if needed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Sep 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17921245260

Details

  • 173 of 220 (78.64%) changed or added relevant lines in 29 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 42.482%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 0 1 0.0%
src/commons/featureFlags/FeatureFlag.ts 9 11 81.82%
src/features/directory/flagDirectoryLanguageUrl.ts 10 12 83.33%
src/features/directory/flagDirectoryPluginUrl.ts 10 12 83.33%
src/commons/sagas/FeatureFlagSaga.ts 8 12 66.67%
src/commons/featureFlags/publicFlags.ts 0 6 0.0%
src/commons/sagas/LanguageDirectorySaga.ts 29 38 76.32%
src/commons/sagas/PluginDirectorySaga.ts 21 31 67.74%
src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts 5 16 31.25%
Files with Coverage Reduction New Missed Lines %
src/commons/featureFlags/publicFlags.ts 1 0.0%
src/commons/featureFlags/index.ts 4 79.31%
src/commons/featureFlags/selectFeatureSaga.ts 7 12.5%
Totals Coverage Status
Change from base Build 17819137218: 0.02%
Covered Lines: 21112
Relevant Lines: 52058
💛 - Coveralls

@tsammeow tsammeow marked this pull request as draft September 20, 2025 10:25
@tsammeow
Merge remote-tracking branch 'origin/master' into conductor/persisten…
27ed739 
…t-ff

# Conflicts:
#	package.json
#	src/commons/controlBar/ControlBarChapterSelect.tsx
#	src/commons/featureFlags/publicFlags.ts
#	src/commons/navigationBar/subcomponents/NavigationBarLangSelectButton.tsx
#	yarn.lock
@tsammeow
rename directory in preparation for adding plugin directory
a8ea7c0
@tsammeow
remove old language directory attempt and clean up
71b1ebc
@tsammeow tsammeow changed the title persistent feature flags and language directory support persistent feature flags, language and plugin directory support Sep 20, 2025
@tsammeow tsammeow marked this pull request as ready for review September 20, 2025 14:49
@tsammeow tsammeow requested a review from s-kybound September 20, 2025 15:15
@tsammeow
fix featureSelector bug
87b6938 
unmodified flags will now give their default value when selected
@tsammeow
fix formatting
8bbe9af
@tsammeow
fix conductor's eval take
72a9e11
@tsammeow tsammeow mentioned this pull request Sep 22, 2025
Closed
@tsammeow tsammeow linked an issue Sep 22, 2025 that may be closed by this pull request
Getting "Error: The context {} is empty, but we are looking for display" for any program #3377
Closed
@s-kybound
Copy link
Member

breaking: reverted language directory to SA version, open a PR to language directory repo if needed

cc @loyaltypollution

s-kybound
s-kybound approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@s-kybound s-kybound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor styling requests in the package.json file, but otherwise once amended LGTM.

@s-kybound
Copy link
Member

@tsammeow all good, feel free to merge

@tsammeow tsammeow merged commit ef84ba5 into master Sep 23, 2025
9 checks passed
@tsammeow tsammeow deleted the conductor/persistent-ff branch September 23, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-kybound s-kybound s-kybound approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting "Error: The context {} is empty, but we are looking for display" for any program

4 participants

@tsammeow @coveralls @s-kybound @martin-henz