Skip to content

Conversation

@jiachen247
Copy link
Contributor

I did most of the heavy lifting but have yet to make it pretty.
Lets merge the others first to prevent merge conflicts:)

@coveralls
Copy link

coveralls commented Jan 11, 2019

Pull Request Test Coverage Report for Build 1072

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 26.075%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/assessment/GradingResult.tsx 5 7 71.43%
Totals Coverage Status
Change from base Build 1067: 0.06%
Covered Lines: 921
Relevant Lines: 2993

💛 - Coveralls

Copy link
Contributor

@rrtheonlyone rrtheonlyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is a really useful feature :)

screenshot 2019-01-13 at 1 30 45 am

Some minor things:

(1) The last line - change to "Graded by avenger name on date"
(2) Why does it say invalid date?

@jiachen247
Copy link
Contributor Author

have fixed both issue. It was an invalid date because in the mocks gradedAt was an empty string. Have updated them to be valid timestamps.

This is how it looks now.

image

@jiachen247
Copy link
Contributor Author

lets try to merge the others first then we can rebase and sort out the conflicts all at one go :)

@rrtheonlyone
Copy link
Contributor

Yup agreed @jiachen247!

@jiachen247 jiachen247 changed the title enhanced grading results tab for students grading results tab for students Jan 13, 2019
Copy link
Contributor

@rrtheonlyone rrtheonlyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants