Skip to content

Conversation

@jiachen247
Copy link
Contributor

Resolves #504

@jiachen247 jiachen247 requested a review from rrtheonlyone April 9, 2019 14:19
@coveralls
Copy link

coveralls commented Apr 9, 2019

Pull Request Test Coverage Report for Build 1374

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+18.09%) to 25.941%

Files with Coverage Reduction New Missed Lines %
src/containers/academy/grading/GradingEditorContainer.ts 1 85.71%
src/containers/assessment/index.ts 1 50.0%
src/containers/academy/grading/index.ts 1 87.5%
src/containers/assessment/AssessmentWorkspaceContainer.ts 1 34.62%
src/containers/ApplicationContainer.ts 1 80.0%
src/containers/academy/grading/GradingWorkspaceContainer.ts 1 34.62%
src/components/workspace/side-content/index.tsx 1 17.65%
src/components/academy/grading/GradingWorkspace.tsx 1 14.52%
src/containers/PlaygroundContainer.ts 1 37.5%
src/containers/LoginContainer.ts 1 87.5%
Totals Coverage Status
Change from base Build 1355: 18.09%
Covered Lines: 922
Relevant Lines: 3005

💛 - Coveralls

Copy link
Contributor

@rrtheonlyone rrtheonlyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much needed change indeed! The .env values are always strings to we have to parse them back to Boolean form.

Previously, I recall having to manually update this constants.ts file to reconfigure the backend.

@martin-henz martin-henz merged commit b5868c3 into master Apr 10, 2019
@thomastanck thomastanck deleted the fix-usebackend branch April 12, 2019 07:39
jiayushe pushed a commit to jiayushe/cadet-frontend that referenced this pull request Apr 13, 2019
* Bump @types/node from 9.6.28 to 11.13.0 (source-academy#513)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 9.6.28 to 11.13.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* fix use backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants