Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSE Machine: Avoid pushing unnecessary env instructions (exhaustive version) #1706

Merged
merged 29 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
da818e4
check if env instruction is necessary
DiligentPenguinn Apr 22, 2024
de09673
Add test cases
DiligentPenguinn Apr 22, 2024
4d26880
Implement helper functions
DiligentPenguinn Apr 22, 2024
067bc95
Fix format
DiligentPenguinn Apr 22, 2024
95c5e7d
Cache isEnvDependent results
DiligentPenguinn Apr 27, 2024
432b1a8
Delete unnecessary comments
DiligentPenguinn Apr 27, 2024
0e0f5db
Merge branch 'master' into cse-machine-simplify-env-instr
DiligentPenguinn Apr 27, 2024
04917eb
Merge branch 'master' into cse-machine-simplify-env-instr
DiligentPenguinn Apr 27, 2024
5504278
Merge branch 'master' into cse-machine-simplify-env-instr
DiligentPenguinn Apr 27, 2024
5e2f015
Speed up env dependent checking, approach 2
DiligentPenguinn Apr 27, 2024
1dd9845
Merge branch 'cse-machine-simplify-env-instr' of https://github.com/s…
DiligentPenguinn Apr 27, 2024
b88ad72
merge
DiligentPenguinn Apr 27, 2024
1dccbcc
Implement exhaustive environment depedent logic 1
DiligentPenguinn May 14, 2024
5e53954
Modify test cases
DiligentPenguinn May 15, 2024
043e7c1
Merge branch 'master' of https://github.com/source-academy/js-slang i…
DiligentPenguinn May 15, 2024
77834d3
resolve conflict
DiligentPenguinn May 15, 2024
0e4fb8f
fix format
DiligentPenguinn May 15, 2024
89f6d85
remove obsolete test cases
DiligentPenguinn May 15, 2024
63e96f3
Fix equality check
DiligentPenguinn May 16, 2024
74ff305
Clean up and add a test case
DiligentPenguinn Jul 20, 2024
4e945c8
remove incompatible instr checks
DiligentPenguinn Jul 20, 2024
855f67a
Merge branch 'master' into cse-machine-simplify-env-instr
DiligentPenguinn Jul 20, 2024
6746e38
Merge branch 'master' of https://github.com/source-academy/js-slang i…
DiligentPenguinn Jul 20, 2024
8fb466b
Double checked the logic
DiligentPenguinn Jul 20, 2024
f282ea9
Fix format
DiligentPenguinn Jul 20, 2024
a7250ea
Merge branch 'cse-machine-simplify-env-instr' of https://github.com/s…
DiligentPenguinn Jul 20, 2024
34ab5b8
Remove unused logic and update test cases
DiligentPenguinn Jul 21, 2024
c09fba3
Merge with master
DiligentPenguinn Sep 10, 2024
c649ea2
Merge branch 'master' into cse-machine-simplify-env-instr
martin-henz Sep 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/cse-machine/__tests__/__snapshots__/cse-machine-heap.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -7467,7 +7467,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"isEnvDependent": false,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -8313,7 +8313,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"isEnvDependent": false,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -9258,7 +9258,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"isEnvDependent": false,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -10222,7 +10222,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"isEnvDependent": false,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -10976,7 +10976,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"isEnvDependent": false,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down Expand Up @@ -11229,7 +11229,7 @@ EnvTree {
"type": "Literal",
"value": [Function],
},
"isEnvDependent": true,
"isEnvDependent": false,
"loc": undefined,
"optional": false,
"type": "CallExpression",
Expand Down
Loading
Loading