Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RFC) utils/rttc.ts: Add integer check for array indices #282

Merged
merged 4 commits into from
Jul 10, 2019

Conversation

thomastanck
Copy link
Member

One way to resolve #279.

@thomastanck thomastanck added the Proposal Proposing a feature, please discuss label Jul 8, 2019
@coveralls
Copy link

coveralls commented Jul 8, 2019

Pull Request Test Coverage Report for Build 1364

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 91.619%

Totals Coverage Status
Change from base Build 1344: 0.02%
Covered Lines: 1712
Relevant Lines: 1847

💛 - Coveralls

@martin-henz
Copy link
Member

I find the current error message not so clear:

Screenshot 2019-07-09 at 12 34 38 PM

Current message:

Line 1: Expected integer as prop, got number.

The problem: the number is actually an integer, by any definition of the word.

My suggestion:

Line 1: Expected array index as key, got other number

@thomastanck
Copy link
Member Author

Thanks for the review, I've just made the error message clearer:

Examples:

Expected array index as prop, got other number.
Expected array index as prop, got string.
...

martin-henz
martin-henz previously approved these changes Jul 10, 2019
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@martin-henz martin-henz dismissed their stale review July 10, 2019 03:20

travis chokes

@martin-henz
Copy link
Member

Travis chokes on the recent change.

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@martin-henz martin-henz merged commit 7c86076 into master Jul 10, 2019
@thomastanck thomastanck deleted the integer-arrays branch July 10, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal Proposing a feature, please discuss
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LANG: Non-integer number keys in arrays
3 participants