-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSG]: Renderer overhaul & fixes #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some testing for regl-renderer but no use. Render hooks on but no image is shown
…ix shiftKey build error, fix regl ts types, add dev comments
…) and change in error encountered, issue with module tab lies elsewhere
…defined potentialShape from destructuring, misc refactoring
…nctionality to CSG
…ported by @jscad/modelling
…ed renderer to show grid correctly.
…t old renderer & abstract jscad functions, tidy & trim down typings
…irst start / last stop, refactoring
…ker, frame performance savings, code improvements, misc fixes
Anonymxtrix
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for helping to fix the problems :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fourth CSG PR focuses on the module's renderer and its related systems. It brings improvements (including to performance) while fixing some bugs.
The main changes include:
Subsequent PRs are still planned. The next will likely be about the new Scenes system