-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize line encodings #210
Standardize line encodings #210
Conversation
No worries, looks like there are now merge conflicts due to the squashing. BTW, is there a specific reason we are choosing CRLF and not LF? |
I've fixed the conflicts From what I can see, there is no particular reason for CRLF, other than the fact that the current eslint rules specify CRLF in particular |
*.js text eof=crlf | ||
*.ts text eof=crlf | ||
*.tsx text eof=crlf | ||
*.md text eof=crlf | ||
*.cjs text eof=crlf | ||
*.json text eof=crlf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there's a typo here:
+ eol=crlf
- eof=crlf
if we want to take things even further we can introduce a ref (it's a great read): https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/ |
Let us just go forward with adding this. I've been searching for the longest time for some way to get vscode to standardize line endings without having to commit |
Let's recreate this branch directly off the latest |
@Yongbeom-Kim what's the status of this PR? |
1 similar comment
@Yongbeom-Kim what's the status of this PR? |
@martin-henz to my understanding, @leeyi45 is incorporating these changes into #244. This original PR can probably be closed. |
OK |
Description
Adds a
.gitattributes
file to standardize all line encoding to CRLF for the following files (LMK if there are any other important files to standardize, or any to omit):Fixes #209
Sequenced after #204 (oops, sorry about that)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Checklist: