Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded function names in error messages #238

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

RichDom2185
Copy link
Member

Description

Removes hardcoding of function names in error messages in sound and stereo_sound modules. This allows for a single source of truth for the function name and reduces the effort required to refactor anything.

Type of change

  • Code quality improvements

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@RichDom2185 RichDom2185 self-assigned this Sep 10, 2023
@RichDom2185 RichDom2185 enabled auto-merge (squash) September 10, 2023 05:34
@martin-henz martin-henz self-requested a review September 10, 2023 06:41
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@RichDom2185 RichDom2185 merged commit a7deb51 into master Sep 10, 2023
1 check passed
@Cloud7050 Cloud7050 deleted the remove-hardcoded-error-names branch November 1, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants