Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sound and stereo_sound: renaming and fixing #239

Merged
merged 9 commits into from
Sep 10, 2023
Merged

sound and stereo_sound: renaming and fixing #239

merged 9 commits into from
Sep 10, 2023

Conversation

martin-henz
Copy link
Member

renaming play and play_concurrently to play_in_tab and play; fixing stereo_sound's play function; fixing user-facing comments

sayomaki
sayomaki requested changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being slightly nit-picky here, but I think the examples documentation changes are worth addressing.

src/bundles/sound/functions.ts Outdated Show resolved Hide resolved
src/bundles/sound/functions.ts Outdated Show resolved Hide resolved
src/bundles/sound/functions.ts Outdated Show resolved Hide resolved
src/bundles/stereo_sound/functions.ts Outdated Show resolved Hide resolved
src/bundles/stereo_sound/functions.ts Outdated Show resolved Hide resolved
src/bundles/stereo_sound/functions.ts Outdated Show resolved Hide resolved
src/bundles/stereo_sound/functions.ts Show resolved Hide resolved
@martin-henz
Copy link
Member Author

Being slightly nit-picky here, but I think the examples documentation changes are worth addressing.

Thanks for the review @sayomaki . I think I've handled all comments.

RichDom2185
RichDom2185 reviewed Sep 10, 2023
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions, thanks!

src/bundles/sound/functions.ts Show resolved Hide resolved
src/bundles/stereo_sound/functions.ts Show resolved Hide resolved
sayomaki
sayomaki reviewed Sep 10, 2023
View reviewed changes
Copy link
Contributor

@sayomaki sayomaki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing to address here, missed it out earlier. The rest looks good, thanks!

Refer to comment within the conversation.

src/bundles/stereo_sound/functions.ts Show resolved Hide resolved
sayomaki
sayomaki approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@martin-henz martin-henz merged commit 1560bc1 into master Sep 10, 2023
1 check passed
@martin-henz martin-henz mentioned this pull request Sep 12, 2023
Merged
@Cloud7050 Cloud7050 deleted the play_in_tab branch November 1, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 left review comments

@sayomaki sayomaki sayomaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-henz @sayomaki @RichDom2185