Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSG module's rgb function #324

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix CSG module's rgb function #324

merged 1 commit into from
Sep 3, 2024

Conversation

coder114514
Copy link
Contributor

Description

Fix the scg module's rgb function.

Fixes #323

Type of change

  • Bug fix (non-breaking change which fixes an issue

RichDom2185
RichDom2185 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution to Source Academy!

@RichDom2185 RichDom2185 changed the title fix scg module's rgb function Fix CSG module's rgb function Sep 3, 2024
@RichDom2185 RichDom2185 enabled auto-merge (squash) September 3, 2024 10:15
@RichDom2185 RichDom2185 merged commit 417d995 into source-academy:master Sep 3, 2024
1 check passed
@coder114514 coder114514 deleted the patch-fix-scg-modules-rgb-function branch September 3, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csg: bug in function rgb
2 participants
@coder114514 @RichDom2185