Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more tests #107

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add some more tests #107

wants to merge 5 commits into from

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Aug 18, 2023 •
edited
Loading

Adds some relatively-straightforward tests in some places.

@RichDom2185 RichDom2185 self-assigned this Aug 18, 2023
@RichDom2185
Copy link
Member Author

@YaleChen299 should AnyOf pass or fail in the trivial case with 0 permissions?

@RichDom2185
Copy link
Member Author

My opinion is:

  • "All of N" → "pass if you fulfil all N requirements" → all of nothing means all requirements out of 0 will always be fulfilled → always pass
  • "Any of N" → "pass if you have at least one out of N" → you can't have at least one permission out of 0 (because there are no permissions in the first place for you to have) → always fail

But this is up for discussion, depending on what makes sense for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaleChen299 YaleChen299 Awaiting requested review from YaleChen299

At least 1 approving review is required to merge this pull request.

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RichDom2185