Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate curved parentheses with smoother curves #41

Merged
merged 3 commits into from
Sep 18, 2018

Conversation

vl4dimir
Copy link
Contributor

The soon-to-be-official u0028-rounder and u0029-rounder alternates are almost perfect, but their curves are messy. This is obvious at larger sizes, but also when viewed on a high DPI (i.e. Retina) screen if you have a sharp eye.

Here's my take on it:

alternate

And here it is overlaid on top of u0028-rounder and u0029-rounder:

comparison

You can see the orange parts sticking out, which are to my eye superfluous. Here's a side-by-side comparison (my mod is blue, the soon-to-be-official is orange):

comparison2

Is it just me, or are these annotated regions (in red) appearing thicker than they should be?

annotated

Anyway, didn't want to complain about it in the Hack repo, so I rolled up my sleeves and fixed it. 😉

@jdw1996
Copy link
Contributor

jdw1996 commented Aug 30, 2018

Thanks for continuing to iterate on the design. These changes look good to me at high resolution, but do you think you could post screenshots at a smaller font size, more like what would be used in code?

@vl4dimir
Copy link
Contributor Author

@jdw1996 Sure! Here's a couple of screenshots.

screen shot 2018-08-30 at 10 59 40
screen shot 2018-08-30 at 10 59 22
screen shot 2018-08-30 at 10 59 12
screen shot 2018-08-30 at 10 59 02
screen shot 2018-08-30 at 10 58 52

Honestly I still feel these would look better if the ends of each stroke were perpendicular to the shape, @chrissimpkins suggested this back on the PR for the round parens. I might do another alternate version soon.

@chrissimpkins
Copy link
Member

Changes look good Vladimir. Thank you very much for working on this! Joseph submitted these in Hack as new defaults and I think that we should be having this discussion on the Hack repository. Let's take the discussion there. Please make sure that you are working off of the design files in the dev branch of the Hack repository where the current versions of the designs reside. These changes are currently part of this PR source-foundry/Hack#427

We can build fonts with these designs and take a look at them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants