Skip to content

#21 remove eloquent enumeration dependency #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2020
Merged

#21 remove eloquent enumeration dependency #23

merged 3 commits into from
Nov 25, 2020

Conversation

NeroAzure
Copy link
Contributor

@NeroAzure NeroAzure commented Oct 19, 2020 •
edited
Loading

Description

  • Added mssing methods from eloquent/enumeration to Enumeration.php.
  • Imported exception classes from eloquent/enumeration into this repo.
  • Removed eloquent/enumeration as dependency.
  • Adapted PHPCS rules.

Missing todos:

  • [ ] Tests for added methods

@NeroAzure NeroAzure added the hacktoberfest-accepted Qualified for Hacktoberfest label Oct 19, 2020
@NeroAzure NeroAzure self-assigned this Oct 19, 2020
@NeroAzure NeroAzure changed the title #21 remove eloquent enumeration dependency WIP: #21 remove eloquent enumeration dependency Nov 17, 2020
@NeroAzure
Copy link
Contributor Author

The last todo of the missing tests will be solved later, as the present tests are still functioning correctly.

@NeroAzure NeroAzure merged commit 12b5c49 into develop Nov 25, 2020
@NeroAzure NeroAzure deleted the feature/21_remove_eloquent_enumeration_dependency branch November 25, 2020 21:12
@NeroAzure NeroAzure changed the title WIP: #21 remove eloquent enumeration dependency #21 remove eloquent enumeration dependency Nov 25, 2020
@NeroAzure NeroAzure mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NeroAzure NeroAzure

Labels
hacktoberfest-accepted Qualified for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NeroAzure