Support Line Number Highlighting

[nevetS]

It would be nice to be able to use this tool in code reviews.

something like repo=repoalias&file=main.py&highlight=20-25,48-49,117

That way, you could leave a comment that had highlighted lines. You could also use it just to share bits of code with other developers - "This is the code we were discussing earlier".

[brendan-kellam]

Thanks for raising the issue! If I understand correctly, this almost sounds like a "deep linking" feature where you are able to make a code selection, right click and "copy link to selection". Does that sound right?

Out of curiosity, what are you using for code reviews? And does it have a feature like this?

[vjo]

+1

I came here to request this exact feature, it's pretty common, see:

• Github:

  sourcebot/packages/web/src/lib/schemas.ts

  Lines 11 to 18 in 83270ff

  	export const locationSchema = z.object({
  	// 0-based byte offset from the beginning of the file
  	ByteOffset: z.number(),
  	// 1-based line number from the beginning of the file
  	LineNumber: z.number(),
  	// 1-based column number (in runes) from the beginning of line
  	Column: z.number(),
  	});

• Gitlab: https://gitlab.com/gitlab-com/marketing/digital-experience/buyer-experience/-/blob/main/app/router.scrollBehavior.js?ref_type=heads#L5-L9
• Sourcegraph: https://sourcegraph.com/github.com/microsoft/TypeScript/-/blob/src/server/editorServices.ts?L299-302

You often need to link someone to a part of the code base.

[KonradStanski]

I feel like this should not be implemented in the query URL path, but for a dedicated code browsing path.
Once this is created, you should be able to select lines and share URLs with the file path and lines selected.
Line selection should probably not be enabled in the query page, since the URL is not persistently shareable in any meaningful way.