Tool call error

[tekinozbek]

Describe the bug

I have a local ollama+sourcebot setup, as well as continue.dev extension on vscode. The MCP server lists the tools correctly, but when using any agent, tool calls fail with:

sourcebot_via_npx_search_code failed with the message: [{"type":"text","text":"[\n  {\n    \"code\": \"invalid_type\",\n    \"expected\": \"object\",\n    \"received\": \"undefined\",\n    \"path\": [\n      \"zoektStats\"\n    ],\n    \"message\": \"Required\"\n  }\n]"}]

At first I thought it might be a problem with the continue.dev extension, so I grabbed mcptools to test it with call search_code --params '{"query":"test"}' and, alas, there it was again:

[
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "undefined",
    "path": [
      "zoektStats"
    ],
    "message": "Required"
  }
]

To reproduce

Set up docker image using ghcr.io/sourcebot-dev/sourcebot:main and a config JSON with:

{
    "$schema": "https://raw.githubusercontent.com/sourcebot-dev/sourcebot/main/schemas/v3/index.json",
    "connections": {
        "local-repos": {
            "type": "git",
            "url": "file:///repos/*"
        }
    }
}

There's a single git repo in there, which is indexed properly. Sourcebot web server search and file explorer works perfectly fine. "Ask Sourcebot" also works fine.

Sourcebot deployment information

Sourcebot version (e.g. v3.0.1): latest main (ghcr.io/sourcebot-dev/sourcebot:main)

[brendan-kellam]

Heya - could you try the latest release tag (v4.7.3)? We introduced a breaking change in the REST api in main and tie MCP package releases with Sourcebot releases.

[tekinozbek]

Yeah that did it. I was using main because I saw you fixed the git permission issues there, but I just do that in my Dockerfile now.

[tekinozbek]

I am however getting nothing but

file: undefined

with my searches now... I wonder if it's because my repo has unicode filenames in it (which the Repositories tree doesn't seem to like).

[brendan-kellam]

yea sorry we have been slow on releases last two weeks (planning on getting a v4.7.4 released today once #563 is in).

with my searches now... I wonder if it's because my repo has unicode filenames in it (which the Repositories tree doesn't seem to like).

are you seeing this for files that don't have any unicode in the filenames?

[tekinozbek]

Yes, I see it for everything. Here's a sample output from mcptools:

repository: localhost/testrepo
language: C++file: undefined
num_matches: 116
repository: localhost/testrepo
language: C++file: undefined
num_matches: 29
repository: localhost/testrepo
language: C++file: undefined
num_matches: 64
repository: localhost/testrepo
language: C++file: undefined
num_matches: 87
repository: localhost/testrepo
language: C++

[tekinozbek]

@brendan-kellam maybe we should close this bug and open a new one, it seems unrelated.

I wonder if this has something to do with the webUrl property not working for local repos? Both search_code and list_repos use file.webUrl and repo.webUrl respectively.

search_code

sourcebot/packages/mcp/src/index.ts

Line 111 in 5b09757

let text = `file: ${file.webUrl}\nnum_matches: ${numMatches}\nrepository: ${file.repository}\nlanguage: ${file.language}`;

file: undefined
num_matches: 1
repository: localhost/~/testrepo
language: C++"

list_repos

sourcebot/packages/mcp/src/index.ts

Line 167 in 5b09757

text: `id: ${repo.repoName}\nurl: ${repo.webUrl}`,

id: localhost/~/testrepo
url: undefined

get_file_source

Works perfectly fine:

sourcebot/packages/mcp/src/index.ts

Line 201 in 5b09757

text: `file: ${fileName}\nrepository: ${repoId}\nlanguage: ${response.language}\nsource:\n${response.source}`,

file: main.cpp
repository: localhost/~/testrepo

Presumably because it just returns the filename passed in, instead of fetching it from a stored value.

I also found getFileWebUrl which might be returning undefined, if it's going through there. I can't seem to be able to connect to the postgres db in any way to inspect it.

sourcebot/packages/web/src/features/search/searchApi.ts

Lines 99 to 106 in 5b09757

	const getFileWebUrl = (template: string, branch: string, fileName: string): string | undefined => {
	// This is a hacky parser for templates generated by
	// the go text/template package. Example template:
	// {{URLJoinPath "https://github.com/sourcebot-dev/sourcebot" "blob" .Version .Path}}
	if (!template.match(/^{{URLJoinPath\s.*}}(\?.+)?$/)) {
	return undefined;
	}