Filter results css #105
Merged
Filter results css #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the filter items were cutoff, the text would break onto multiple lines and the count would overlap with the text
|
Thank you! Could you paste in a before / after screenshot in your PR description? |
Just did this. |
brendan-kellam
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple things which seemed to not be working with the filter results panel:
It makes the filter result panel 100% of parent height, and set the repo filtering to be at max 50%. It then lets the language filter fill the remaining height.
This fixes the repo display name text such that it does not split with long repo names onto multiple lines, instead showing an ellipsis and gracefully being cut off.
It also puts the count into a box.
It also adds cutoff for both search bars to display the number of languages/ repos matched, and cut them off at 100.
In this case the text becomes 100+
Do the same for the result counts but cut them off at 999. It makes the text 999+
Before:
After:
Before:
After:
